Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_peer_handle for serializing inference state using wrong numpy type #629

Open
risingsunomi opened this issue Jan 24, 2025 · 0 comments

Comments

@risingsunomi
Copy link

Currently, there is a function that detects if running Apple based systems or not. It then sets an mx variable that points to either mlx or numpy depending on your system.

This causes issues when adding more than one node to the network and passing the inference state.

https://github.com/exo-explore/exo/blob/main/exo/networking/grpc/grpc_peer_handle.py#L203

Current fix suggestion is by adding a boolean IS_APPLE to check and later assigning a variable mx_array_type the proper type

https://github.com/risingsunomi/exo-pt/blob/grpc-fix-jan242025/exo/networking/grpc/grpc_peer_handle.py#L17-L22

https://github.com/risingsunomi/exo-pt/blob/grpc-fix-jan242025/exo/networking/grpc/grpc_peer_handle.py#L206-L211

My fork has too many changes to do a pull request.

Thank you and appreciate all your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant