Improve description of "simple-cipher" + give perspective (for others as well) #2515
Conversation
The description was only show the special case where the key is a repeating letter, but not the general case. That was good for showing how shift ciphers are a special case of substitution ciphers, but not really for showing the full generality of the Vigenere. Also, name the Vigenere cipher (which step 2 is all about): having the name allows people to read more about it. Also, the Vigenere is a special case of substitution ciphers, which are more general.
We should not leave readers with the impression that the Vigenere is OK if the key is not too small and spaces are hidden, or that the cipher from crypto square fixes all its known issues. Give pointer to actual modern crypto.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
Follow up -> https://forum.exercism.org/t/14253 |
This PR: