[perfect-numbers] backticks on math and removed parens #2319
Conversation
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
habere-et-dispertire
changed the title
| - 24 is an abundant number because (1 + 2 + 3 + 4 + 6 + 8 + 12) = 36 | ||
| - **Deficient**: aliquot sum < number | ||
| - 8 is a deficient number because (1 + 2 + 4) = 7 | ||
| - **Perfect**: when a `number` equals its `aliquot sum` |
There was a problem hiding this comment.
Should number and aliquot sum be quoted rather than code blocked?
There was a problem hiding this comment.
It's perhaps easier to read wth the code blocks marking them as variables which also draws us to their earlier mention -- but I don't mind. It currently looks like
The aliquot sum is defined as the sum of the factors of a number not including the number itself.
For example, the aliquot sum of 15 is 1 + 3 + 5 = 9.
- Perfect: when a
numberequals itsaliquot sum - Abundant: when a
numberis less than itsaliquot sum - Deficient: when a
numberis greater than itsaliquot sum
There was a problem hiding this comment.
I thought we were describing the idea, rather than actual code. It seems that aloquot sum may or may not be an invocation of a function or method in some languages.
I definitely will not stand in the way of it though.
It could look like:
The "aliquot sum" is defined as the sum of factors of a number not including the number itself.
For example, the "aliquot sum" of 15 is 1 + 3 + 5 or 9.
- Perfect: when
numberequals its "aliquot sum" - Abundant: when
numberless than its "aliquot sum" - Deficient: when
numbergreater than its "aliquot sum"
There was a problem hiding this comment.
The aliquot sum is defined as the sum of factors of a number not including the number itself. For example, the aliquot sum of 15 is 1 + 3 + 5 or 9.
- Perfect: when
numberequals its aliquot sum - Abundant: when
numberless than its aliquot sum - Deficient: when
numbergreater than its aliquot sum
—-
Italics to me emphasize the technical term aliquot sum but also distinct from other terms that are bolded, a different category of emphasis. Quote marks to me don’t convey that much emphasis compared to italics.
There was a problem hiding this comment.
I would also prefer bolding it
There was a problem hiding this comment.
The reason I kept the emphasis on each occurrence was because perfect, abundant, and deficient are also bolded in later occurrences. It’d make sense though to only emphasize the first occurrence so maybe that needs to fixed as well
There was a problem hiding this comment.
I've turned them into links referencing the relevant heading.
There was a problem hiding this comment.
Everyone happy with this ?
There was a problem hiding this comment.
Wasn't terrible to start out with, but still looking much better now!
Taking contributor concerns into play I've also italicized only the defining instance of aliquot sum.
|
Just waiting on the code owner approval... looking good, though. |
|
@ErikSchierboom ping 🙂 |
Thanks @MatthijsBlom 🌷
See : #2318 (comment)