RFE: Reduce project's JS/CSS payload size

[pradyunsg]

Is your feature request related to a problem? Please describe.

Currently, this extension results in 50+ kB of assets across 7+ network requests to be added to each page for a project's documentation.

Describe the solution you'd like

Significantly lowered payload size (drop the dependency on semantic-ui?) and consolidate CSS/JS files to reduce the number of network requests needed.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

This would also make it easier for "downstream" themes to customize how the tabs look, if the CSS for this project is self-contained in a single file. :)

[welcome]

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

[chrisjsewell]

Also, I've recently realised that its not too hard to add js only for specific pages, i.e. those containing tab nodes (see executablebooks/sphinx-book-theme#165 (comment)).
So I think this would be a complimentary improvement

[pradyunsg]

Would you be open to a complete rewrite of this package, similar to what I did for sphinx-autobuild? 👀

[chrisjsewell]

Not really lol, I've already set it up consistent with the EBP guidelines in #76

Obviously I'm open to suggestions and improvements where beneficial.
But I will never agree to using a src folder 🤣

[Daltz333]

src for python is just weird....

[chrisjsewell]

src for python is just weird....

FYI, I mainly said this to "pull @pradyunsg's leg", since I know he is a bit of a fan pypa/packaging.python.org#320 lol

[pradyunsg]

Obviously I'm open to suggestions and improvements where beneficial.

Noxify!

[chrisjsewell]

Noxify!

Well there already a tox.ini.
I'd rather just use that for 2 reasons

1. tox is just more mature and well-used/known
2. I personally use also the tox-conda plugin which is super useful, and I don't see a nox equivalent (apart from hard-coding conda into nox.py itself)

nox has its uses; the live-rebuilds for messing around with scss in sphinx-book-theme is helpful.
But I'm not sure, for a project less based around theming, that the pros outweigh the cons?

[pradyunsg]

Fair enough. :)

As long as my finger-memory of `.ox -s (tests?|lint|docs) works, I'm a happy kiddo. :)

[chrisjsewell]

nox -s lint was actually a nitpick I noted in sphinx-book-theme/autobuild.
Surely its redundant to create a virtualenv, in which to run pre-commit, which then creates its own virtualenv 😜

[pradyunsg]

It is super redundant. OTOH, the main reason I do this is consistency across projects (not all my projects use pre-commit, yet!) and newbie-friendliness. It's easier to tell newcomers to "install nox, and use these nox commands" than "install nox and pre-commit, and use pre-commit for linting, everything else uses these nox commands".

And for anyone familiar enough with pre-commit, well, pre-commit run --all-files still works. :)

[chrisjsewell]

linking executablebooks/meta#119

[pradyunsg]

@chrisjsewell Thoughts on a complete rewrite of this project, to drop the dependency on semantic-ui + works with CSS-only w/ JS for "advanced" features like grouped tabs? It should make it easier to tweak the JS to implement stuff like #84 and #47.

[chrisjsewell]

I'd say possibly, but it's low on the priority list.
Obviously we now have, https://sphinx-panels.readthedocs.io/en/latest/#tabbed-content for a CSS only approach,
and first I'd like to get executablebooks/meta#137 sussed

[pradyunsg]

This RFE is still valid, and @foster999 has made #94, which looks like it does the needful. I'm not gonna come around to this myself anytime soon though. Context here.