Demodulize class name on mailer method lookup #331
StanisLove
started this conversation in
General
Replies: 2 comments
-
Makes sense to me. Do you want to submit a PR for that? |
Beta Was this translation helpful? Give feedback.
0 replies
-
@excid3 hi! What you think about @StanisLove PR? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, mailer method is defined as an underscored class name if the
method
option wasn't providednoticed/lib/noticed/delivery_methods/email.rb
Lines 36 to 43 in df561f3
But if I put my notification class to a module the result string will contain the name of that module as a prefix.
I think it is appropriate to pre-demodulize a class name here.
Beta Was this translation helpful? Give feedback.
All reactions