Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evcc hängt sich auf wenn Ladeplan existiert #18250

Closed
1 task done
naltatis opened this issue Jan 16, 2025 · 3 comments · Fixed by #18256
Closed
1 task done

evcc hängt sich auf wenn Ladeplan existiert #18250

naltatis opened this issue Jan 16, 2025 · 3 comments · Fixed by #18256
Assignees
Labels
bug Something isn't working

Comments

@naltatis
Copy link
Member

Describe the bug

Vmtl. eine Regression von #18211

Auszug aus /debug/pprof

goroutine 998 [sync.RWMutex.Lock, 1 minutes]:
sync.runtime_SemacquireRWMutex(0xc001a4b401?, 0x30?, 0x23369e2?)
	runtime/sema.go:105 +0x25
sync.(*RWMutex).Lock(0x5935560?)
	sync/rwmutex.go:153 +0x6a
github.com/evcc-io/evcc/core.(*Loadpoint).maxActivePhases(0xc0018cb008)
	github.com/evcc-io/evcc/core/loadpoint_phases.go:105 +0xf3
github.com/evcc-io/evcc/core.(*Loadpoint).EffectiveMaxPower(0xc0018cb008)
	github.com/evcc-io/evcc/core/loadpoint_effective.go:205 +0x28
github.com/evcc-io/evcc/core.(*Loadpoint).nextVehiclePlan(0xc0018cb008)
	github.com/evcc-io/evcc/core/loadpoint_effective.go:85 +0x5a9

Steps to reproduce

  1. Ladeplan (statisch oder wiederholend) an einem Fahrzeug anlegen (getestet mit Tesla)
  2. Keine Updates mehr im Log

Configuration details

-

Log details

-

What type of operating system or environment does evcc run on?

Docker container

Nightly build

  • I have verified that the issue is reproducible with the latest nightly build

Version

No response

@andig
Copy link
Member

andig commented Jan 16, 2025

EffectiveMaxPower früher abfragen?

@naltatis naltatis changed the title evcc hängt sich auf, wenn Ladeplan existiert evcc hängt sich auf wenn Ladeplan existiert Jan 17, 2025
@naltatis
Copy link
Member Author

@andig ist dieser Lock überhaupt notwendig?
https://github.com/evcc-io/evcc/blob/fix/gok/core/loadpoint_plan.go#L65-L66

@andig
Copy link
Member

andig commented Jan 17, 2025

Fehler gefunden. Da muss ein lock in rlock verwandelt werden.

@naltatis naltatis added the bug Something isn't working label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants