Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-js-modal test code issue from 2.0.0 #739

Open
mercedesbenz00 opened this issue Nov 26, 2021 · 1 comment
Open

vue-js-modal test code issue from 2.0.0 #739

mercedesbenz00 opened this issue Nov 26, 2021 · 1 comment
Labels

Comments

@mercedesbenz00
Copy link

mercedesbenz00 commented Nov 26, 2021

Problem:

Cannot do unit test for vue-js-modal from 2.0.0.
Because in https://github.com/euvl/vue-js-modal/blob/master/src/PluginCore.js, show/hide function is defined as const.
So we can not mock for unit test.

I think there is no way to test in this case, maybe need to remove const for show/hide function.
Thanks.

Version:

v2.0.1

Example & screenshots:

image

I have checked stackoverflow for solutions and 100% sure that this issue is not not related to my code.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant