Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualize the Icon Browser list #600

Open
joebochill opened this issue Nov 23, 2022 · 2 comments
Open

Virtualize the Icon Browser list #600

joebochill opened this issue Nov 23, 2022 · 2 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature

Comments

@joebochill
Copy link
Collaborator

Describe the desired behavior

The IconBrowser page should only render enough icons to fill the screen at one time.

Describe the current behavior

Right now all of the icons are rendered (>2000) and it causes poor performance on the Icon Browser page

Is this request related to a current issue?

Performance issues

Additional Context

There should be a number of third party libraries (or something in MUI) that we can use to do this.

@joebochill joebochill added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review labels Nov 23, 2022
@huayunh
Copy link
Contributor

huayunh commented Dec 8, 2022

(This might be a MUI v5 thing; the existing docit icons page loads within a tolerable time)

@jeffvg jeffvg removed the needs-review Issues that we would like to revisit/review label Dec 8, 2022
@joebochill
Copy link
Collaborator Author

Yes, this is post-MUI5 conversion. The number of icons (DOM nodes) on the page has nearly doubled with the addition of the new icons.

@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Development

No branches or pull requests

3 participants