You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
py-evm hogs the eth namespace, preventing other packages seeking to utilize it as well (skellet0r/eth-stdlib#1).
How can it be fixed
Rename the eth directory to evm, and place it inside of the eth namespace.
Ex.
├── src
│ └── eth
│ └── evm
│ ├── db
│ └── estimators.py
│ └── ...
│ └── __init__.py
This would be a breaking change, and downstream users, would merely have to change any imports of 'eth' to 'eth.evm', a simple grok. This is fine since py-evm has yet to even reach v1.0.0, and it's breaking changes are expected/condoned.
Hey @skellet0r. I'd be on board with this for sure. I think as soon as we get some of the bigger changes in, we can refactor this structure before the next release.
What is wrong?
py-evm hogs the eth namespace, preventing other packages seeking to utilize it as well (skellet0r/eth-stdlib#1).
How can it be fixed
Rename the eth directory to evm, and place it inside of the eth namespace.
Ex.
This would be a breaking change, and downstream users, would merely have to change any imports of 'eth' to 'eth.evm', a simple grok. This is fine since py-evm has yet to even reach v1.0.0, and it's breaking changes are expected/condoned.
https://packaging.python.org/en/latest/guides/packaging-namespace-packages/
related: #1849
The text was updated successfully, but these errors were encountered: