-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/added toml supersim config closes #104 #295
Open
s29papi
wants to merge
6
commits into
ethereum-optimism:main
Choose a base branch
from
s29papi:feat/added-toml-supersim-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/added toml supersim config closes #104 #295
s29papi
wants to merge
6
commits into
ethereum-optimism:main
from
s29papi:feat/added-toml-supersim-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s29papi
changed the title
Feat/added toml supersim config
Feat/added toml supersim config closes #104
Dec 5, 2024
jakim929
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Mostly looks great Left some comments
- Explicitly passed flags should always override file based config
- Not have separate type definitions for CLIConfig
- Some nit readme updates
Abuchtela
approved these changes
Jan 4, 2025
requesting a review on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements significant improvements to the configuration handling of the application. The changes include the addition of a TOML configuration file that is parsed, allowing values to be passed in as command-line arguments. The configuration values from the TOML file take precedence over those provided via CLI flags, ensuring a more flexible and user-friendly configuration experience.
Tests
Comprehensive tests have been added to verify the correct parsing of the TOML file and the proper application of configuration values. The tests ensure that:
Additional context
These improvements address the need for a more robust configuration management system, allowing users to define their settings in a structured format while still providing the flexibility of command-line overrides. This change enhances usability and aligns with best practices for configuration management.
Metadata