-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prefix all addresses with l1 or l2 depending on chain #3
Comments
An alternative is to call this folder L1Addresses instead of addresses |
Currently they are all L1, and they will likely always be L1, as the L2 protocol contracts all have their own standard predeploy address ( |
@protolambda it's pretty inconvenient to not have them here though. For example, I want viem and ethers to use this as the source of truth and instead they are forced to use a different package. one package for l1 addresses and a different package for l2 addresses |
Same thing for folks just trying to find contract addresses. Many folks like myself will land here looking for addresses and be confused when they can't find the l2 ones. Is there any good reason to not include them? |
A reasonable compromise here in my opinion would be to change the folder to be See #21 Fine with closing if we discover an alternative solution we prefer. |
The text was updated successfully, but these errors were encountered: