Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get supported qemu targets from tools json #1405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

Description

Use $IDF_PATH/tools/tools.json to obtain QEMU forks supported targets. From now any IDF_TARGET is mapped to them and fallback to esp32 and esp32c3 forks.

Fixes #1404

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "[QEMU Server]" on the status bar and run either QEMU Debug or Monitor. It should select the new esp32s3 (when available in ESP-IDF tools.json) target.
  2. Execute action.
  3. Observe results.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing running any QEMU command (Debug, Monitor) to make sure IDF_TARGET is used to get the QEMU fork to use (xtensa or risc-v)

Test Configuration:

  • ESP-IDF Version: 5.4
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.9.1 milestone Jan 20, 2025
@brianignacio5 brianignacio5 self-assigned this Jan 20, 2025
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated information about supported QEMU targets (VSC-1568)
2 participants