-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fitsio failing to build wheel for pip based install on github. #414
Comments
Can you try installing libbz2 in the container? |
Probably something like |
I can give a little context: pip cannot install the bzip2 library, so it is up to the user to make sure it is available. My guess is the github containers may no longer be including that library as part of the standard set of installations. |
That does work, but we have something like 60 or so workflows, and I'd rather not have to update them all. |
That's like 4-5 workflows per package across somethink like 12-15 packages. |
This is out of my control. Neither I or the fitsio package are affiliated with github I think you have a few options:
|
FWIW, I worked around this issue by adding the following to my ci.yml file:
This seems to have worked for me. |
Hi @esheldon, have you thought about providing wheels for fitsio? The process is pretty much automatic with cibuildwheel (here an example of mine) |
@beckermr do you have ideas about this proposal? |
@ntessore I think this would not fix the issue of bz2, since that is linked as a shared library. The library would still need to be installed, but pip can't do that. The reason it "just works" for conda is because conda installs its own bz2 as a dependency. |
IIUC cibuildwheel will take care of the shared libraries using auditwheel/delocate |
I think that's right. GalSim uses it and it works correctly with the FFTW library. |
You can use our wheels.yml as a template if you want: |
Yes if people want wheels, we can ship them. We still need to ship the sdist as well. I do not like wheels but lots of folks do. Best to give the people what they want. |
You don't like wheels, because you always use conda. Wheels are for people who don't use conda. :) But yes, the last thing. |
💯 that's correct @rmjarvis :) |
It looks like the specific error is:
configure: error: Unable to locate bz2 library needed when enabling bzip2 support; try specifying the path
You can find an example here:
https://github.com/LSSTDESC/rail_pipelines/actions/runs/12282370023/job/34273426914
The text was updated successfully, but these errors were encountered: