Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve (de)activation of capabilities #304

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Conversation

ChristopherMann
Copy link
Collaborator

This PR fixes some corner cases where catlet capabilities were not correctly activated or deactivated.

Closes #289

@ChristopherMann ChristopherMann marked this pull request as ready for review January 17, 2025 13:05
Copy link
Member

@fw2568 fw2568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Just a little wording thing - "turned off" is not a status we have in eryph, so better would be:
Cannot change [setting] if the catlet is not stopped. Stop the catlet and retry.

@ChristopherMann ChristopherMann merged commit 140ab15 into main Jan 21, 2025
10 checks passed
@ChristopherMann ChristopherMann deleted the pull/fix-capabilities branch January 21, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Memory is always enabled even if not configured
2 participants