Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag for setting custom bittorrent tracker and/or peers for snapshot downloader #13502

Open
taratorio opened this issue Jan 20, 2025 · 4 comments
Labels
erigon3 imp2 Medium importance

Comments

@taratorio
Copy link
Member

request from @tornadocontrib on discord (discussion)

Currently we use these public trackers that are hardcoded in the code here to get bittorrent peers. We can add a flag to allow users to change that to their custom tracker. Similarly it would be nice if we have an option to specify a peer list directly in addition to that.

Potential use cases may be:

  • from Alex: "i have large private infrastructure. i want to start our own internal Downloader server X (like go run ./cmd/downloader --seedbox) - and I would like all our new Erigon nodes download data from X (so traffic goes by private network instead of public - which is cheaper and faster)."
  • from @tornadocontrib: "retrieving backups with validation or seeding multiple clusters of nodes ( can be useful for rpc providers )"
@AskAlexSharov AskAlexSharov added the imp2 Medium importance label Jan 20, 2025
@dvovk
Copy link
Member

dvovk commented Jan 21, 2025

It can't be solved by just adding a flag, we need to do much more work with the torrent lib and downloader. We've gotten webseeds download working good but still have some issues in p2p flow. I think this issue should be a part of bigger one. I think it makes sense to create "downloader" project.

@shohamc1
Copy link
Member

@dvovk
Copy link
Member

dvovk commented Jan 21, 2025

@shohamc1 I didn't say that it isn't supported I said that in order to make p2p work on the same level as webseeds (Mark made significant changes). At the moment p2p isn't well tested and I know that it has issues with download/upload speed. It is work which still needs to be done.

@shohamc1
Copy link
Member

@dvovk Ah, I misunderstood you then. Of course we would need to address the p2p speed issue - I reckon this will be a smaller issue if the torrent peers are on the same network (which seems to be the primary use case for this).

Perhaps we can ban webseeds if this flag is enabled? (not sure if the library supports this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erigon3 imp2 Medium importance
Projects
None yet
Development

No branches or pull requests

4 participants