Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge bot failures #87

Open
ericdill opened this issue Mar 3, 2023 · 0 comments
Open

conda-forge bot failures #87

ericdill opened this issue Mar 3, 2023 · 0 comments

Comments

@ericdill
Copy link
Owner

ericdill commented Mar 3, 2023

the conda-forge bot was failing to detect any imports with depfinder in this PR: regro/cf-scripts#1619. Turns out it's because the comparison code in reports.py, specifically this line was using the full file path to do the fnmatch comparison:

DEBUG    depfinder:reports.py:168 ******found ignore match for name: /usr/share/miniconda3/envs/test/conda-bld/praw_1677855233037/work/praw/reddit.py

The conda env in the conda-forge bot CI was named "test", so that was, of course, matching on */test/*

The fix here is for depfinder to strip the path so that we're only considering stuff below the working directory in the above example. ie., need to split this:

full_path=/usr/share/miniconda3/envs/test/conda-bld/praw_1677855233037/work/praw/reddit.py

into

workdir=/usr/share/miniconda3/envs/test/conda-bld/praw_1677855233037/work/

and

fname=praw/reddit.py

and then do the comparison on fname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant