Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critEd commits are not displayed #160

Open
arlogriffiths opened this issue Sep 4, 2024 · 5 comments
Open

critEd commits are not displayed #160

arlogriffiths opened this issue Sep 4, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@arlogriffiths
Copy link
Contributor

dear @michaelnmmeyer — I have been working since 2024-08-31 with @aso2101 on the file DHARMA_CritEdSmaradahana.xml and associated translation files. None of the commits made over the past days have led to modification of tghe html display. Here are my last two commits:

e30c98d
8ec673a

Besides direct changes in the critEd xml file itself, we are not seeing the translation files (for an existing Dutch translation and an English translation that is work in progress, so far only canto 1) being matched with the corresponding stanzas in the display of the edition.

For other critical editions, like Svayambhu, the workflow does seem to be operational.

Can you help us debug this situation? Thanks!

@arlogriffiths arlogriffiths added the bug Something isn't working label Sep 4, 2024
@arlogriffiths
Copy link
Contributor Author

update. after tweaking the teiHeader of one of the two transl. files (the Dutch one) in bf7a88f, the pipeline does suddenly seem to have been launched and edits to the edition are becoming visible, though we still see this counterfactual message:

Capture d’écran 2024-09-04 à 11 09 15

@michaelnmmeyer
Copy link
Member

The file's original name was DHARMA_CritEdSmaradahana, but it was renamed to DHARMA_CritEdKakavinSmaradahana. However, the HTML file generated from DHARMA_CritEdSmaradahana was still there, so we had in fact two displays of the same original file. You were probably looking at DHARMA_CritEdSmaradahana instead of the newer DHARMA_CritEdKakavinSmaradahana.

As concerns the message that says no translations are available, the problem is that the display of translations has not been implemented so far---not even speaking of the parallel display of several translations of the same text.

@arlogriffiths
Copy link
Contributor Author

thanks. can you remove the html generated from DHARMA_CritEdSmaradahana? by the way, that file is not brought up if I search https://dharmalekha.info/texts?q=Smaradahana&s=title so I don't think I was looking at the wrong html...

I am aware that parallel display of more than one translation must not have been implemented by Axelle so far. but I think display of a single translation should be. see e.g. https://erc-dharma.github.io/tfd-nusantara-philology/output/critical-edition/html/DHARMA_CritEdSiksaGuru.html, where translation is correctly matched with text.

@michaelnmmeyer
Copy link
Member

I already removed the duplicate HTML file. For the translation, indeed, my mistake. It works now.

@arlogriffiths
Copy link
Contributor Author

thanks a lot. do you understand why the translation is not matched to the edition stanza per stanza, and we get the Translation box only at the end of the Canto? Contrast this with https://erc-dharma.github.io/tfd-nusantara-philology/output/critical-edition/html/DHARMA_CritEdSiksaGuru.html where each <p> (I think, but maybe there are enclosing <div>s) gets its own translation. As it stands, the presentation of the translation of canto 1 (which I presume is representative for other cantos too) is very chaotic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants