You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Custom keys in the example testdata configuration do not match the schema generated by webviz schema, and increases risk of users defining custom keys that we later want to use ourselves:
suggestion:
Include a new dict key like custom_settings, app_settings or etc where the users can define whatever they want, and which is included in the autogenerated webviz schema from webviz-config as a reserved key that we will not use for anything else later.
-> if included, we will need a PR in webviz-config
The text was updated successfully, but these errors were encountered:
Custom keys in the example testdata configuration do not match the schema generated by
webviz schema
, and increases risk of users defining custom keys that we later want to use ourselves:webviz-subsurface-testdata/webviz_examples/webviz-full-demo.yml
Lines 18 to 84 in 6a4b3e9
suggestion:
Include a new dict key like
custom_settings
,app_settings
or etc where the users can define whatever they want, and which is included in the autogeneratedwebviz schema
fromwebviz-config
as a reserved key that we will not use for anything else later.-> if included, we will need a PR in webviz-config
The text was updated successfully, but these errors were encountered: