Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where site config was not propagated to Everest config #9719

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix bug where site config was not propagated to Everest config #9719

wants to merge 5 commits into from

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 13, 2025 •
edited
Loading

Issue
Resolves #9783

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9719 will degrade performances by 10.3%

Comparing oyvindeide:change_site_config (1017e5d) with main (945e198)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main oyvindeide:change_site_config Change
❌ test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6.3 ms 7.1 ms -10.3%

@oyvindeide oyvindeide force-pushed the change_site_config branch 8 times, most recently from da1f1db to 1d74782 Compare January 16, 2025 08:27
@oyvindeide oyvindeide self-assigned this Jan 16, 2025
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 16, 2025
@oyvindeide oyvindeide force-pushed the change_site_config branch 2 times, most recently from 116ec8f to f9b110d Compare January 17, 2025 08:31
@oyvindeide oyvindeide changed the title Add function to propagate context to validation Fix bug where site config was not propagated to Everest config Jan 17, 2025
@oyvindeide oyvindeide force-pushed the change_site_config branch 5 times, most recently from 1ae7af5 to e8f8737 Compare January 17, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oyvindeide oyvindeide

Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different queue requirements for ert and everest
1 participant
@oyvindeide