Revert refactor that caused tests to be flaky #9758
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9758 will not alter performanceComparing Summary
|
oyvindeide
reviewed
Jan 16, 2025
| @@ -305,7 +304,8 @@ def main(): | |||
| simulation_callback=partial(_sim_monitor, shared_data=shared_data), | |||
| optimization_callback=partial(_opt_monitor, shared_data=shared_data), | |||
| ) | |||
| if run_model._queue_config.queue_system == QueueSystem.LOCAL: | |||
|
|
|||
| if config.simulator.queue_system.name == "local": | |||
There was a problem hiding this comment.
Not sure this will fail, but:
if run_model._queue_config.queue_system.lower() == QueueSystem.LOCAL.lower():might be safer. Would we be able to test this?
There was a problem hiding this comment.
Why is it lower in the first place?
I think we should merge this as it is as we know that will fix the problem at hand
There was a problem hiding this comment.
Because everest user lower while ert uses upper. Changed it for ert here: 68ab17b, so should always be lower now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9738
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable