Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): disable fields after editing shared app (Issue #3017) #3033

Merged
merged 23 commits into from
Jan 29, 2025

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Jan 28, 2025

Description:

Fix issue where fields (Name, Version, Icon) remain disabled in the 'Add App' form after editing a shared app.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

IlyaBondar and others added 22 commits December 10, 2024 18:15
@Derikyan Derikyan added the bug Something isn't working label Jan 28, 2025
@Derikyan Derikyan self-assigned this Jan 28, 2025
@Derikyan
Copy link
Contributor Author

Derikyan commented Jan 28, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3033.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan enabled auto-merge (squash) January 28, 2025 18:11
@Derikyan Derikyan merged commit 6c315f6 into development Jan 29, 2025
8 checks passed
@Derikyan Derikyan deleted the fix/3017-disable-fields-edit-shared-app branch January 29, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants