Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): get rid of redundant models requests, fix duplications from approve required section, fix organization section and folders highlight (Issues #2978, #2183) #3011

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

Alexander-Kezik
Copy link
Contributor

@Alexander-Kezik Alexander-Kezik commented Jan 24, 2025

Description:

get rid of redundant models requests
fix duplications from approve required section
fix organization section and folders highlight

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

…m approve required section, fix organization section and folders highlight (Issues #2978, #2183)
@Alexander-Kezik Alexander-Kezik added the bug Something isn't working label Jan 24, 2025
@Alexander-Kezik Alexander-Kezik self-assigned this Jan 24, 2025
@Alexander-Kezik Alexander-Kezik marked this pull request as draft January 24, 2025 13:14
@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3011.nightly-test.deltixhub.io
E2E tests status: failed

1 similar comment
@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3011.nightly-test.deltixhub.io
E2E tests status: failed

@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3011.nightly-test.deltixhub.io
E2E tests status: success

@Alexander-Kezik Alexander-Kezik marked this pull request as ready for review January 24, 2025 16:04
@Alexander-Kezik Alexander-Kezik merged commit a2bc02a into development Jan 24, 2025
8 checks passed
@Alexander-Kezik Alexander-Kezik deleted the fix/settings-opening-models-uploading branch January 24, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants