Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): handle required schema buttons, fix name regenerate, improve schema validation (Issue #2980, #2901, #2972, #2986) #3005

Merged
merged 14 commits into from
Jan 24, 2025

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Jan 24, 2025

Description:

  • add simple type validator for checking schema
  • add support for required schema buttons
  • add configuration schema into the context of generating conversation name
  • fix absent agent version in empty chat description
  • fix mobile context menu opening if click schema button

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir added bug Something isn't working enhancement New feature or request _priority_1 labels Jan 24, 2025
@Gimir Gimir self-assigned this Jan 24, 2025
@Gimir
Copy link
Contributor Author

Gimir commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3005.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3005.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir enabled auto-merge (squash) January 24, 2025 12:02
@Gimir Gimir merged commit 952be60 into development Jan 24, 2025
8 checks passed
@Gimir Gimir deleted the feat/2980-required-button branch January 24, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request _priority_1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants