Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix application dialog issues (Issue #2247, #2251, #2262) #2292

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Oct 4, 2024

Description:

  • Save /Add buttons for custom app form should be synchronised with fields' validation
  • Incorrect url format should be validated and hint error should be displayed if input format is not correct
  • When user click 'x' icon on 'Select application icon' or 'Settings -> Custom logo' form, then action should be treated as Cancel: no changes should be applied

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Oct 4, 2024
@Derikyan Derikyan self-assigned this Oct 4, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Oct 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2292.nightly-test.deltixhub.io
E2E tests status: success

Copy link
Contributor

@Gimir Gimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find time and refactor jsx a little bit for later (move handlers & validators to separate functions)

@Derikyan Derikyan enabled auto-merge (squash) October 4, 2024 10:47
@Derikyan Derikyan merged commit 3f9987d into development Oct 4, 2024
9 checks passed
@Derikyan Derikyan deleted the fix/2247-completion-url-validation-end-dot branch October 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants