Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix error message on application delete (Issue #2021) #2068

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Sep 5, 2024

Description:

  • remove duplicate update conversation dispath after deleting model.
    There is already dispatched action for selecting next recent model, which contains update conversation dispatch

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir added the bug Something isn't working label Sep 5, 2024
@Gimir Gimir self-assigned this Sep 5, 2024
@Gimir
Copy link
Contributor Author

Gimir commented Sep 5, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2068.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor

Derikyan commented Sep 9, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2068.nightly-test.deltixhub.io
E2E tests status: success

@Gimir
Copy link
Contributor Author

Gimir commented Sep 10, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2068.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir merged commit d76ad4f into development Sep 10, 2024
9 checks passed
@Gimir Gimir deleted the fix/2021-delete-app-tost branch September 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants