Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Fixed delete 'shared with me' attachments (Issue #2005) #2010

Merged

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Aug 30, 2024

Description:

  • Fixed deletion of 'Shared with me' attachments list.. All selected attachments now disappear when the delete button is clicked.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Aug 30, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2010.nightly-test.deltixhub.io
E2E tests status: success

@irinakartun
Copy link
Contributor

irinakartun commented Sep 10, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2010.nightly-test.deltixhub.io
E2E tests status: success

@IlyaBondar IlyaBondar merged commit a5befa4 into development Sep 10, 2024
9 checks passed
@IlyaBondar IlyaBondar deleted the fix/2005-manage-attachments-shared-with-me-delete branch September 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants