Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed bug in collection of text context parts #90

Merged
merged 5 commits into from
Jan 15, 2025
Merged

fix: fixed bug in collection of text context parts #90

merged 5 commits into from
Jan 15, 2025

Conversation

adubovik
Copy link
Collaborator

@adubovik adubovik commented Dec 27, 2024 •
edited
Loading

Analytics didn't correctly collect content from the text content parts like this one:

{
  "messages": [
    {
      "role": "user",
      "content": [
        {
          "type": "text",
          "text": "xxxx"
        }
      ]
    }
  ]
}

because of a typo in the content field name:

ai-dial-analytics-realtime/aidial_analytics_realtime/dial.py

Lines 45 to 49 in 492e8a2

if isinstance(content_part, dict):
if content_part.get("type") == "text" and (
text := content_part.get("content")
):
ret.extend(text)

The typo content -> text was fixed.

Also, the whitespace strings are removed from the content.

@adubovik adubovik self-assigned this Dec 27, 2024
@adubovik adubovik requested a review from Allob as a code owner December 27, 2024 15:06
@adubovik adubovik merged commit 7526bca into development Jan 15, 2025
6 checks passed
@adubovik adubovik deleted the fix/fixed-content-gathering branch January 15, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allob Allob Allob approved these changes

Assignees

@adubovik adubovik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adubovik @Allob