Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction's name or conditions text wraps incorrectly in specific cases: the last line before truncating, removing of special symbols, empty line instead of "..." #2647

Closed
ivanmaslow opened this issue Nov 22, 2024 · 1 comment · Fixed by #2640
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Low

Comments

@ivanmaslow
Copy link
Collaborator

Steps to Reproduce - the last line and special symbols issue

  1. Load from RDF the reaction with name, conditions and truncating:
    text-issue-8.zip
    image

Actual Result

  • The last line doesn't contain 27 symbols and "...", some special symbols are lost (":", ">"):
    image

Expected Result

  • The last line contains 27 symbols and "...", special symbols aren't lost

Steps to Reproduce - last line is empty

  1. Load from RDF the reaction with name and truncating:
    text-issue-9.zip
    image

Actual Result

  • The last line is empty, no information that some part of conditions were removed "...":
    image

Expected Result

  • The last line should contain information that conditions are lost

Environment Details

  • Tested on aws_ci SA env with Ketcher-master and Indigo-2404-ket-to-rdf branches
  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-22; 06:47:10
  • Indigo Version 1.27.0-dev.1.49-gbbd67f22-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)

Additional Context

@ivanmaslow ivanmaslow added Bug Priority: Low Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Nov 22, 2024
@ivanmaslow ivanmaslow changed the title Reaction's name or conditions text wraps incorrectly in specific cases: the last line before truncating, removing of special symbols, empty line instead of ... Reaction's name or conditions text wraps incorrectly in specific cases: the last line before truncating, removing of special symbols, empty line instead of "..." Nov 22, 2024
@even1024 even1024 linked a pull request Nov 22, 2024 that will close this issue
7 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2024

 Tested. Bug fixed.

2024-12-06_11h12_06

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.1]
Indigo version
[Version 1.27.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants