Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valence is not added to the SMARTS file #1362

Closed
urszula-gawlowska opened this issue Oct 20, 2023 · 0 comments · Fixed by #1384
Closed

Valence is not added to the SMARTS file #1362

urszula-gawlowska opened this issue Oct 20, 2023 · 0 comments · Fixed by #1384
Assignees
@AliaksandrDziarkach
Labels
epic: smarts
Milestone
Indigo-SMART-Enha...

Comments

@urszula-gawlowska
Copy link
Collaborator

Steps to Reproduce
Convert structure with set up valence property into SMARTS format

Expected behavior
Valence value should be added to the SMARTS like this:

[#6](-[#6])(-[#6])-[#6;v4]

Actual behavior
Valence is not added to the SMARTS:

[#6](-[#6])(-[#6])-[#6]

Indigo/Bingo version
Version 1.15.0-dev.4.0-g4bfe0976e-x86_64-linux-gnu-11.2.1

Additional context
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 22, 2023 that will close this issue
#1362 Valence is not added to the SMARTS file #1366
Closed
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Oct 25, 2023
#1362 Valence is not added to the SMARTS file #1366
Closed
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 25, 2023 that will close this issue
#1362 Valence is not added to the SMARTS file #1379
Merged
AliaksandrDziarkach added a commit that referenced this issue Oct 26, 2023
@AliaksandrDziarkach
#1362 Valence is not added to the SMARTS file (#1379)
86722e0
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Oct 26, 2023
#1362 Valence is not added to the SMARTS file #1379
Merged
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 26, 2023 that will close this issue
Backmerge #1362 Valence is not added to the SMARTS file (#1379) #1384
Merged
AlexanderSavelyev pushed a commit that referenced this issue Oct 26, 2023
@AliaksandrDziarkach
Backmerge #1362 Valence is not added to the SMARTS file (#1379) (#1384)
d4c2809
@github-project-automation github-project-automation bot moved this to Done in Indigo Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
epic: smarts
Projects
Indigo
Status: Done
Milestone
Indigo-SMART-Enhancement
Development

Successfully merging a pull request may close this issue.

Backmerge #1362 Valence is not added to the SMARTS file (#1379)
2 participants
@AliaksandrDziarkach @urszula-gawlowska