Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide where to put DQ macros #22

Open
lewisarmistead opened this issue May 2, 2023 · 0 comments
Open

decide where to put DQ macros #22

lewisarmistead opened this issue May 2, 2023 · 0 comments

Comments

@lewisarmistead
Copy link
Collaborator

Currently, the flag macros migrated over from the entr_warehouse project are duplicated in dbt-entr and dbt-openoa - we need to decide whether these fit in the dbt-entr package or are more specific to OpenOA. They're also not super handy generally, but DQ check patterns that can be applied to the ENTR warehouse table schemas would be. My gut right now is that they're not compelling enough to include in dbt-entr, and they're not adding much value to dbt-openoa currently - it might be best to remove the flag macros entirely unless we envision them to be more useful to stakeholders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant