Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the confusion between the various platform objects #392

Open
itziakos opened this issue Mar 12, 2021 · 4 comments
Open

Cleanup the confusion between the various platform objects #392

itziakos opened this issue Mar 12, 2021 · 4 comments
Labels

Comments

@itziakos
Copy link
Member

itziakos commented Mar 12, 2021

There are several platform objects EPDPlatform, LegacyEPDPlatform and Platform. The objects do not really hold the same Information and It is not clear when each object should be used. Even worse the code converts between them by first converting to strings which in most cases results in loss of information.

@itziakos itziakos added the bug label Mar 12, 2021
@itziakos
Copy link
Member Author

itziakos commented Jun 28, 2023

  • LegacyEDPlatform should be removed
  • EPDPlatform should be a set of functions and factories that holds information based on historical Platforms that we have used at Enthought so far. This is to be used for special usecases only.
  • Platform should be the instance that should be used by all downstream tools

@itziakos
Copy link
Member Author

#452 remove the use of the LegacyEPDPlatform from the okonomiyaki code (the LegacyEPDPlatform is still available)

@itziakos
Copy link
Member Author

itziakos commented May 9, 2024

#458 removes the legacy module

@itziakos
Copy link
Member Author

It looks that we cannot tottaly remove the use of EPDPlatform without updating the egg metadata. The code in EPDPlatform is there to guess the Platform instance based on the limited information in our egg metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant