Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionedUnpickler depends on private implementation details of _Unpickler #232

Open
aaronayres35 opened this issue Nov 23, 2020 · 0 comments

Comments

@aaronayres35
Copy link
Contributor

As described in this comment chain: #199 (comment)

The apptools.persistence.versioned_unpickler.NewUnpickler class currently depends on an attribute dispatch defined on the _Unpickler class from pickle, which is not intended to be public. Further this is forcing VersionedUnpickler to continue using _Unpickler not the Unpicklerwhich comes from the faster _pickle (see here: https://github.com/python/cpython/blob/aa01011003bb855cd52abfd49f2443446590d913/Lib/pickle.py#L1772-L1787).

Ultimately, we should remove the dependency on dispatch which is part of a private interface, and evolve VersionedUnpickler to be able to use Unpickler / not be tied to _Unpickler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant