You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The apptools.persistence.versioned_unpickler.NewUnpickler class currently depends on an attribute dispatch defined on the _Unpickler class from pickle, which is not intended to be public. Further this is forcing VersionedUnpickler to continue using _Unpickler not the Unpicklerwhich comes from the faster _pickle (see here: https://github.com/python/cpython/blob/aa01011003bb855cd52abfd49f2443446590d913/Lib/pickle.py#L1772-L1787).
Ultimately, we should remove the dependency on dispatch which is part of a private interface, and evolve VersionedUnpickler to be able to use Unpickler / not be tied to _Unpickler.
The text was updated successfully, but these errors were encountered:
As described in this comment chain: #199 (comment)
The
apptools.persistence.versioned_unpickler.NewUnpickler
class currently depends on an attributedispatch
defined on the_Unpickler
class frompickle
, which is not intended to be public. Further this is forcingVersionedUnpickler
to continue using_Unpickler
not theUnpickler
which comes from the faster_pickle
(see here: https://github.com/python/cpython/blob/aa01011003bb855cd52abfd49f2443446590d913/Lib/pickle.py#L1772-L1787).Ultimately, we should remove the dependency on
dispatch
which is part of a private interface, and evolveVersionedUnpickler
to be able to useUnpickler
/ not be tied to_Unpickler
.The text was updated successfully, but these errors were encountered: