Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an acceptance test for the logic provided by service:head-data #96

Open
bartocc opened this issue Dec 3, 2023 · 0 comments
Open

Comments

@bartocc
Copy link
Contributor

bartocc commented Dec 3, 2023

PR ember-learn/guides-source#1980 on ember-learn/guides-source removes a unit test on service:head-data

This service is not provided by ember-learn/guides-source, but rather by empress/guidemaker and as such, should be tested here.

It should be tested with an acceptance test though, not a unit test, and the logic in test https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.js could should probably be replicated.

This issue is here to remind us that this test should be added at some point, since this service won't be tested anymore once ember-learn/guides-source#1980 gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant