Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite reload whe working with ember-guides #27

Open
Charizard opened this issue Dec 2, 2019 · 4 comments
Open

Infinite reload whe working with ember-guides #27

Charizard opened this issue Dec 2, 2019 · 4 comments

Comments

@Charizard
Copy link

This happened when working with guides-source. Maybe, it's just a setup issue with just that project.

Steps to replicate:

  1. Start server.
  2. Open a page in the browser.
  3. Edit the file for the page and save.
  4. After watcher picks up the change and rebuilds, there is continuous reload request.
@jenweber
Copy link
Contributor

I think this is caused if you use yarn install in the guides instead of npm install, since it skips the lockfile, and we have a fragile dependency. Can you confirm if this is still the case after npm install?

@jgwhite
Copy link

jgwhite commented Jan 3, 2020

I’ve encountered this with a freshly-npm-installed set of dependencies too (and a volta-supplied node 10.16.3). Seems to occur when a requests lands prior to the build completing.

@mansona
Copy link
Member

mansona commented Jan 9, 2020

This should now be fixed 🎉 If you want to try it out you can test this branch ember-learn/guides-source#1264

Let me know if this is still an issue and I'll try to recreate

@jenweber
Copy link
Contributor

WIP to fix this in the Ember guides can be found here: ember-learn/guides-source#1269 and ember-learn/guides-source#1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants