From 35ea64ace7edb9f8be30c6c05083f25769a8ffa1 Mon Sep 17 00:00:00 2001 From: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Tue, 19 Nov 2024 19:38:38 -0500 Subject: [PATCH] Avoid calling List.contains as it is O(n) (#787) --- xplat/src/main/java/dev/emi/emi/registry/EmiTags.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java b/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java index ca602f3a..ee5e5958 100644 --- a/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java +++ b/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java @@ -106,7 +106,7 @@ public static EmiIngredient getIngredient(Class clazz, List sta if (keys != null) { for (TagKey key : keys) { List values = (List) TAG_CONTENTS.get(key); - map.keySet().removeAll(values); + values.forEach(map::remove); } } else { keys = Lists.newArrayList(); @@ -117,7 +117,7 @@ public static EmiIngredient getIngredient(Class clazz, List sta continue; } if (map.keySet().containsAll(values)) { - map.keySet().removeAll(values); + values.forEach(map::remove); keys.add(key); } if (map.isEmpty()) {