Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import myAttr from "ember-data/attr" #23

Open
dcyriller opened this issue Jul 29, 2019 · 0 comments
Open

Support import myAttr from "ember-data/attr" #23

dcyriller opened this issue Jul 29, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@dcyriller
Copy link
Member

dcyriller commented Jul 29, 2019 •
edited
Loading

Whereas import attr from "ember-data/attr" is supported, import myAttr from "ember-data/attr" is not (yet). It will be ignored by the codemod.

updateExistingLiteralPaths function should be updated to support it.

Note that aliased named import are supported: import { hasMany as many } from "ember-data/relationships" is properly turned into import { hasMany as many } from "@ember-data/model".

Related discussion: #21 (comment)
@dcyriller dcyriller added the enhancement New feature or request label Jul 29, 2019
@dcyriller dcyriller mentioned this issue Jul 29, 2019
Merged
@dcyriller dcyriller changed the title Support named imports Support default named imports Jul 30, 2019
@dcyriller dcyriller changed the title Support default named imports Support import myAttr from "ember-data/attr" Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcyriller