Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the New Leaderboard Space #1847

Open
x-tabdeveloping opened this issue Jan 21, 2025 · 8 comments
Open

Renaming the New Leaderboard Space #1847

x-tabdeveloping opened this issue Jan 21, 2025 · 8 comments
Labels
leaderboard issues related to the leaderboard

Comments

@x-tabdeveloping
Copy link
Collaborator

Currently, the new leaderboard is called Leaderboard 2 Demo on the HuggingFace Space.
Since we are planning on releasing the new leaderboard soon we should probably rename the space to something that's more indicative of what it is.

Our suggestion with @KennethEnevoldsen is that we rename the space to embedding-leaderboard as we expect MIEB to be part of the same Space once it is implemented.

As per @imenelydiaker 's suggestion the most reasonable course of action seems to be to add a banner to the old leaderboard saying that you should try out the new one, and then after a transition period, redirect traffic to the new leaderboard directly.

If you have any suggestions or comments regarding this, please comment. @Muennighoff @isaac-chung @Samoed @orionw @tomaarsen

@x-tabdeveloping x-tabdeveloping added the leaderboard issues related to the leaderboard label Jan 21, 2025
@x-tabdeveloping
Copy link
Collaborator Author

@tomaarsen it also seems that renaming the Space is blocked unless we specify payment information. It might be the case that the free grant on the CPU upgrade instance is tied to the current name of the HF Space.

@x-tabdeveloping x-tabdeveloping changed the title Renaming the Leaderboard Space Renaming the New Leaderboard Space Jan 21, 2025
@isaac-chung
Copy link
Collaborator

I recall there was some concern over how likes/stars can be preserved. Would the current approach be able to achieve that?

@tomaarsen
Copy link
Member

The likes will only be preserved if we push the new demo code into the old Space repository.

I think that would be a pretty reasonable solution, but we'd have to change our automatic update script on GitHub.

Regarding payment: I also think that's related to the CPU grant, normally it shouldn't require payment to rename something. I can remove the community grant and reapply it after renaming, but it depends if we want to go with renaming or with pushing the new code into the old repository (to preserve the likes).

Personally, I think it might be reasonable to push the new code into the old repository, push the old code into a separate repository, and make a link from the v2 to the v1.
However, ideally we'd like for e.g. MTEB(eng, classic) in v2 to be equivalent to v1.

  • Tom Aarsen

@x-tabdeveloping
Copy link
Collaborator Author

Okay in light of that, overwriting the old leaderboard does seem like the most reasonable option. Let's make sure we are on top of our game and the leaderboard is as bug-free and faithful to the original as humanly possible.

@isaac-chung
Copy link
Collaborator

overwriting the old leaderboard does seem like the most reasonable option ... ... the leaderboard is as bug-free and faithful to the original as humanly possible.

push the old code into a separate repository, and make a link from the v2 to the v1.

It doesn't sound like there's extra unnecessary pressure on it being bug-free, as we can push the old code into a separate repo first (so it exists in 2 places), then push the new code into the old repo. That way, we still have time to hash things out, as suggested by @imenelydiaker and @tomaarsen. This part was clear to me and I hope we're on the same page on this as well.

@x-tabdeveloping
Copy link
Collaborator Author

Yes @isaac-chung we're in complete agreement. I'm just saying if we get the old URL and old stars instantly, and the new leaderboard is not opt-in but opt-out at launch, then we should be more careful, as opposed to if it was opt-in for a couple of weeks and then would become the default as @imenelydiaker suggested on Slack.

@isaac-chung
Copy link
Collaborator

isaac-chung commented Jan 21, 2025

Oh gotcha. I missed that part, thanks! 👍👍

@Samoed
Copy link
Collaborator

Samoed commented Jan 21, 2025

Could you add me to the Slack?😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
leaderboard issues related to the leaderboard
Projects
None yet
Development

No branches or pull requests

4 participants