-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flycheck-display-errors-delay
must be larger than sideline-delay
for this to work
#2
Comments
Hmm... this may sounds like a trouble! What would you propose to fix this issue? Add documentation? Code fix? etc. |
Well I guess ideally we should eliminate the async process mixed by the two different timers. I can think of two ways:
How do you think? |
The problem of this approach is that, the re-rendering of sideline (currently based on if the symbol-at-point is different?) may not correctly update flycheck errors (e.g. one symbol contains multiple errors at different chars?) |
The first option sounds like more trouble since you will force render other backends as well. I would go for the second option if we go for code fix! I suggest to add a note to the README so users acknowledge this issue. Having multiple timers seems to be normal in Emacs world, albeit awkward. I don't want to abandon flycheck's timer since it opens option to users, so other frontend packages may co-exists with this plugin. They should able to cancel other UI frontends if they only want sideline to be the only to appear on the screen. |
Apparently it currently works like this:
sideline-render
is called after an idle timer ofsideline-delay
(default 0.2s)sideline-render
, it callssideline-flycheck
backend which is async.sideline-flycheck
only keeps the callback for future useflycheck-display-error-at-point
is called after an idle timer offlycheck-display-errors-delay
(default 0.9s)flycheck-display-error-at-point
, it callssideline-flycheck--show
which in turn calls the sideline render callback in step 2.So this process only works when
flycheck-display-error-at-point
is larger thansideline-delay
.The text was updated successfully, but these errors were encountered: