Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_command.sh improvements #751

Open
sirikid opened this issue Oct 23, 2023 · 1 comment
Open

run_command.sh improvements #751

sirikid opened this issue Oct 23, 2023 · 1 comment

Comments

@sirikid
Copy link
Contributor

sirikid commented Oct 23, 2023

wallaby/priv/run_command.sh

Lines 12 to 13 in ef44515

local pid1=$1
local pid2=$1

Should not there be $1 and $2?
@mhanberg
Copy link
Member

I thought that as well a while ago, but after testing it, it seemed to not work the same (or, better), so I left it how it is.

A measurable improvement would be a welcome contribution!

@mhanberg mhanberg changed the title Possible bug in run_command.sh run_command.sh improvements Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirikid @mhanberg