Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never autojoin deactivated & suspended users. #18073

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Never autojoin deactivated & suspended users. #18073

merged 9 commits into from
Jan 28, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Jan 10, 2025 •
edited
Loading

This PR changes the logic so that deactivated users are always ignored. Suspended users were already effectively ignored as Synapse forbids a join while suspended.

@github-actions github-actions bot deployed to PR Documentation Preview January 10, 2025 14:38 Active
@Half-Shot Half-Shot marked this pull request as ready for review January 13, 2025 10:40
@Half-Shot Half-Shot requested a review from a team as a code owner January 13, 2025 10:40
@Half-Shot Half-Shot changed the title Handle deactived & suspended users for automatic invites Never autojoin deactived & suspended users. Jan 13, 2025
@anoadragon453 anoadragon453 changed the title Never autojoin deactived & suspended users. Never autojoin deactivated & suspended users. Jan 27, 2025
devonh
devonh approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion of the existing logic looks good to me.
Also, the new logic makes sense.

One small issue with an errant comment in the tests, otherwise everything looks good.

tests/events/test_auto_accept_invites.py Outdated Show resolved Hide resolved
@devonh devonh merged commit 628351b into element-hq:develop Jan 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@devonh devonh devonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @turt2live @devonh