Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Mark a room or dm as favourite #2197

Closed
3 tasks done
VolkerJunginger opened this issue Nov 17, 2023 · 3 comments
Closed
3 tasks done

[Story] Mark a room or dm as favourite #2197

VolkerJunginger opened this issue Nov 17, 2023 · 3 comments
Labels
App: ElementX Android App: ElementX iOS Rust: Easy SDK tasks should be doable by any developer like FFI export or small behavior changes T-Epic Issue is at Epic level T-User Story X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Nov 17, 2023

Description

As a user that has favourite room I want to mark these as favourites so that I can find the fast.

Figma

Acceptance criteria

  • A room can be (un-) marked as favourite form the room-list and the room-details-page.
  • There must be a visual (star-icon) in the room-headder (@amshakal ?) to show the user that this room is a favourite

Leads

Size estimate

S/M/L

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

Preview Give feedback
No tasks being tracked yet.

Subtasks

Android

Preview Give feedback
  1. A-Room T-Task
    ganfra

iOS

Preview Give feedback
  1. A-Room T-Task

Rust

Preview Give feedback
  1. A-Sync enhancement

Other

Preview Give feedback
No tasks being tracked yet.

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@jplatte
Copy link

jplatte commented Nov 21, 2023

Favorite rooms are stored under m.favourite room account data. This should be pretty easy to integrate into RoomInfo on the Rust side, and expose to EX.

@jplatte jplatte added the Rust: Easy SDK tasks should be doable by any developer like FFI export or small behavior changes label Nov 21, 2023
@manuroe manuroe added the T-Epic Issue is at Epic level label Jan 8, 2024
@manuroe
Copy link
Member

manuroe commented Jan 8, 2024

@amshakal we would need some guidance on the design. Legacy apps do not have the same behavior.

@manuroe manuroe removed the X-Needs-Product More input needed from the Product team label Jan 8, 2024
@amshakal
Copy link

amshakal commented Jan 9, 2024

Not sure about adding a star to the room header but lets start with adding a button in the room details page. I added designs for it. I am slightly skeptical of changing the copy from favourite to un-favourite like we do for mute, unmute as the word is too long so would like to check if thats okay with everyone.
Mark room as favourite:
Screenshot 2024-01-09 at 4 59 00 pm

Mark DM as favourite:
Screenshot 2024-01-09 at 4 59 05 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS Rust: Easy SDK tasks should be doable by any developer like FFI export or small behavior changes T-Epic Issue is at Epic level T-User Story X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

6 participants