Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace os.system with subprocess #73

Closed
jberkus opened this issue Sep 27, 2022 · 1 comment · Fixed by #76
Closed

Replace os.system with subprocess #73

jberkus opened this issue Sep 27, 2022 · 1 comment · Fixed by #76

Comments

@jberkus
Copy link
Member

jberkus commented Sep 27, 2022

Our code uses os.system() in several places. This is a deprecated approach in Python. We should go through and replace it with subprocess(), partly for the benefit in trapping errors.

Ref #72
mscherer added a commit to mscherer/elekto that referenced this issue Sep 28, 2022
@mscherer
Simplify sync by cloning in a temporary directory
87f7fdc 
See elekto-io#72 and elekto-io#73
@mscherer mscherer mentioned this issue Sep 28, 2022
Closed
mscherer added a commit to mscherer/elekto that referenced this issue Sep 28, 2022
@mscherer
Simplify sync by cloning in a temporary directory
7fbf740 
See elekto-io#72 and elekto-io#73
mscherer added a commit to mscherer/elekto that referenced this issue Sep 28, 2022
@mscherer
Simplify sync by cloning in a temporary directory
179f99a 
See elekto-io#72 and elekto-io#73
@jberkus
Copy link
Member Author

jberkus commented Sep 29, 2022

Opinions on using subprocess.call() vs. subprocess.run()? Python 3.5 is 7 years old now, requring it doesn't seem like a major issue.

@jberkus jberkus mentioned this issue Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all os.system() calls with suprocess.run() elekto-io/elekto
1 participant
@jberkus