Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some styling fixups for the todo app #2128

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

msfstef
Copy link
Contributor

@msfstef msfstef commented Dec 9, 2024

Some style fixups for the TODO app as requested. I didn't keep the actual Electric colors cause we are using shadcn themed components so I just went with a similar color. I also hardcoded dark mode as it looks better. Good enough for this IMO but let me know.

Screenshot 2024-12-09 at 18 23 42 image

@thruflo
Copy link
Contributor

thruflo commented Dec 10, 2024

Could you swap the background and green for the background and our brand pink/purple as per the write-patterns example:

image

@msfstef msfstef force-pushed the msfstef/fix-up-todo-app-styling branch from c6b5661 to 2deddb7 Compare December 10, 2024 09:11
@msfstef
Copy link
Contributor Author

msfstef commented Dec 10, 2024

image

should be ok to merge now

@msfstef msfstef merged commit a2903ed into main Dec 10, 2024
30 of 32 checks passed
@msfstef msfstef deleted the msfstef/fix-up-todo-app-styling branch December 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants