Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments script for Todos app #2109

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Deployments script for Todos app #2109

merged 6 commits into from
Dec 9, 2024

Conversation

balegas
Copy link
Contributor

@balegas balegas commented Dec 6, 2024

  • add to GH action
  • clean docker image a bit more

Will not add to GH action because we're going the spend all replication slots with all demos. Would be nice to generate an image with all demos and share a single database. I don't think this is very hard.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Nothing major.
Note that CI is failing because of some type errors that need to be solved before we can merge.

examples/todo-app/Dockerfile Show resolved Hide resolved
examples/todo-app/server.js Outdated Show resolved Hide resolved
examples/todo-app/src/routes/index.tsx Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@balegas balegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks For the comment Kevin

examples/todo-app/Dockerfile Show resolved Hide resolved
examples/todo-app/server.js Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
examples/todo-app/sst.config.ts Outdated Show resolved Hide resolved
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit bfe8f29
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/675721d502242700092f38b2
😎 Deploy Preview https://deploy-preview-2109--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@balegas balegas merged commit 4b1680a into main Dec 9, 2024
30 of 32 checks passed
@balegas balegas deleted the balegas/todo-sst branch December 9, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants