-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deployment guide, with supporting config and integrations. #1836
Conversation
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HUGE upgrade! Looks really nice! I can't claim to to have done a super detailed review as that would have taken 1 more hour but I did skim through every new page at least 😇
I made a few suggestions here and there that should be quick to resolve.
4a827f1
to
3f38523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all amazing, just a couple of comments. Great work!
|
||
### AWS Terraform | ||
|
||
We have an example Terraform repo at [electric-sql/terraform-aws](https://github.com/electric-sql/terraform-aws). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the old electric, do we want to link to it without it being updated?
@thruflo it was easier to just push the changes directly as the merge needed cleaning up |
b323679
to
49e5e5f
Compare
Fleshing out deployment guide. To support it, added a sync service config page in the api docs section and specific integrations pages for various deployment platforms.
Quite a lot to review here. Check out the:
Note that:
As @KyleAMathews commented on Discord, these might be better to include in the monorepo and update using a GitHub action. Perhaps that can be a subsequent Issues / PR.
The integrations also include a Phoenix page which is based on merging #1833 and publishing an updated release for https://hexdocs.pm/electric_phoenix/0.1.0-dev-2/Electric.Phoenix.html
Note that the deployment docs all assume a single
DATABASE_URL
, i.e.: this is pre multi-tenant.