Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync service's supervision tree design leads to invalid startup sequences #1817

Closed
alco opened this issue Oct 9, 2024 · 1 comment
Closed
Assignees

Comments

@alco
Copy link
Member

alco commented Oct 9, 2024

We have the root supervision tree in the Application module but it's really bare bones. The process trees reponsible for maintaining individual shapes are started at a later point in time, on demand.

The current design and split of different sub-supervisors between files makes the initialization sequence too opaque. As a consequence, we have a failure state caused by a Snapshotter process trying to access the database before the DB connection pool has been started. See, for example,

To fix this, we need to reorganize the code such that the start sequence for the core processes, such as the replication client and the DB connection pool, is clearly visible in the code and clearly happens before shape-specific supervision trees are started.

@msfstef
Copy link
Contributor

msfstef commented Oct 21, 2024

Closing this as @alco 's PRs addressing this have now been merged

@msfstef msfstef closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants