chore: Refactor shape_id -> shape_handle for clearer name #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
msfstef
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
@KyleAMathews I've rebased and fixed all the tests, so this should also be ready to merge
I do need to mention that this (and the other refactring PR #1798) might cause issues with rebasing with @kevin-dp multitenancy PR
|
Yeah either way it'll be annoying to rebase... I don't care which way we go. |
|
Is anything left in this PR? Let's merge it if not. Needs to be coordinated with #1833 |
icehaunter
added a commit
that referenced
this pull request
Nov 5, 2024
…params (#1900) Included renames: - `electric-chunk-last-offset` -> `electric-offset` - `electric-next-cursor` -> `electric-cursor` - `electric-shape-id` -> `electric-handle` - `?shape_id` -> `?handle` Added query parameter: `?table` instead of `/:table` in the path Closes #1771, #1796, #1798 --------- Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: msfstef <[email protected]> Co-authored-by: Ilia Borovitinov <[email protected]>
|
Superseded by #1900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of the renames proposed in #1771
shapeIdas well