Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only SQLException are catched by most of actions/triggers #58

Open
2 tasks
stas-fomenko opened this issue Nov 19, 2020 · 0 comments
Open
2 tasks

Only SQLException are catched by most of actions/triggers #58

stas-fomenko opened this issue Nov 19, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@stas-fomenko
Copy link
Contributor

Description: Seems that only SQLException are catched by most of actions/triggers

Example:
STR

  1. Flow: simple trigger --> action upsert row by primary key
  2. use elasticio_testdb test db
  3. input invalid data
    image
  4. Retrieve sample

AR:

  1. Retrieved sample with actual state of row in DB
    2.No error thrown
  2. Erorr in logs
java.lang.IllegalArgumentException
	at java.sql.Date.valueOf(Date.java:143)
	at io.elastic.jdbc.utils.Utils.setStatementParam(Utils.java:150)
	at io.elastic.jdbc.query_builders.Query.executeUpsert(Query.java:242)
	at io.elastic.jdbc.actions.UpsertRowByPrimaryKey.execute(UpsertRowByPrimaryKey.java:87)
	at io.elastic.sailor.impl.MessageProcessorImpl.processMessage(MessageProcessorImpl.java:68)
	at io.elastic.sailor.impl.MessageConsumer.handleDelivery(MessageConsumer.java:71)
	at com.rabbitmq.client.impl.ConsumerDispatcher$5.run(ConsumerDispatcher.java:149)
	at com.rabbitmq.client.impl.ConsumerWorkService$WorkPoolRunnable.run(ConsumerWorkService.java:104)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

ER: Error thrown

TODO

  • reviwe code -- check where Only SQLException are catched
  • fix error handling -- catch all errors that DB throws
@stas-fomenko stas-fomenko added bug Something isn't working enhancement New feature or request labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant