Skip to content
This repository has been archived by the owner on Nov 22, 2017. It is now read-only.

Friendlier error message if user enters a bad expression #16

Open
joshuar opened this issue Nov 15, 2015 · 0 comments
Open

Friendlier error message if user enters a bad expression #16

joshuar opened this issue Nov 15, 2015 · 0 comments

Comments

@joshuar
Copy link

joshuar commented Nov 15, 2015

If I enter something other than a .es() function in the (search?) bar, I get the following error:

Timelion: Error: Expected: "$" @ character undefined
OK
Error: Expected: "$" @ character undefined
    at /opt/kibana/installedPlugins/timelion/handlers/lib/parse_sheet.js:15:15
    at arrayMap (/opt/kibana/node_modules/lodash/index.js:1406:25)
    at Function.map (/opt/kibana/node_modules/lodash/index.js:6710:14)
    at parseSheet (/opt/kibana/installedPlugins/timelion/handlers/lib/parse_sheet.js:9:12)
    at Object.processRequest (/opt/kibana/installedPlugins/timelion/handlers/chain_runner.js:172:11)
    at handler (/opt/kibana/installedPlugins/timelion/routes/sheet.js:24:29)
    at Object.internals.handler (/opt/kibana/node_modules/hapi/lib/handler.js:93:36)
    at /opt/kibana/node_modules/hapi/lib/handler.js:28:23
    at [object Object].internals.Protect.run (/opt/kibana/node_modules/hapi/lib/protect.js:56:5)
    at exports.execute (/opt/kibana/node_modules/hapi/lib/handler.js:22:22)
    at /opt/kibana/node_modules/hapi/lib/request.js:370:13
    at iterate (/opt/kibana/node_modules/hapi/node_modules/items/lib/index.js:35:13)
    at done (/opt/kibana/node_modules/hapi/node_modules/items/lib/index.js:27:25)
    at /opt/kibana/node_modules/hapi/node_modules/hoek/lib/index.js:841:22
    at process._tickDomainCallback (node.js:381:11)

This could be a more informative and shorter error telling the user they need to enter a .es() format, or even bring up the tutorial again?

@joshuar joshuar changed the title Friendlier error message if user enters a non .es() Friendlier error message if user enters a non .es() term Nov 15, 2015
@rashidkpc rashidkpc changed the title Friendlier error message if user enters a non .es() term Friendlier error message if user enters a bad expression May 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants