Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Fix updating old SLO with non-revision bump #206320

Closed
kdelemme opened this issue Jan 10, 2025 · 1 comment · Fixed by #207090
Closed

[SLO] Fix updating old SLO with non-revision bump #206320

kdelemme opened this issue Jan 10, 2025 · 1 comment · Fixed by #207090
Assignees
Labels
Team:obs-ux-management Observability Management User Experience Team v8.18.0

Comments

@kdelemme
Copy link
Contributor

kdelemme commented Jan 10, 2025

Summary

Incident: https://elastic.slack.com/archives/C087YQPEJ30

A change in the tags definitions of a few SLOs have been pushed which triggered an update without bump in the revision. This means only the ingest pipeline was updated to propagate the new tags to the summary documents.
Unfortunately, the SLO was on a previous version, and its summary transform was not generating specific fields that are expected by the latest ingest pipeline in order to compute some fields (the burn rate values).

When updating an SLO, we should check if the SLO is running on the latest version or not, and consider any changes as a breaking change if it is not on the latest version.
Updating the name when the SLO is on the latest version should not trigger a revision change, but updating the name when the SLO is on a previous version should trigger a revision change, and therefore a full reinstallation.

@kdelemme kdelemme self-assigned this Jan 10, 2025
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 10, 2025
@kdelemme kdelemme added the Team:obs-ux-management Observability Management User Experience Team label Jan 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-management Observability Management User Experience Team v8.18.0
Projects
None yet
2 participants